The code below needs some changes. It prints only values at last index of array. Please suggest some changes.

Question

1.00/5 (1 vote)

See more:

Here are the two codes:
1.Avenger.java

Java

package com.avengers;

public class Avenger {

     String[] name = {"Iron Man","Captain America","Thor","Black Widow","Hulk"};
     String[] weapon = {"Repulsor","Shield","Stormbreaker","Baton","Mjolnir"};
     String[] planet = {"Titan","Earth","Asgard","Vormir","Sakaar"};
     int[] age = {48,27,1500,34,58};
     int[] power = {9,10,20,6,8};
     String names,weapons,planets;
     int ages,powers;

    public void getDetails() {
        for(int i=0;i<5;i++){
            names = name[i];
            ages = age[i];
            powers = power[i];
            weapons = weapon[i];
            planets = planet[i];
        }
    }

    public void displayDetails() {
            System.out.println("Name: " + names);
            System.out.println("Age: " + ages);
            System.out.println("Power: " + powers);
            System.out.println("Weapon: " + weapons);
            System.out.println("Planet: " + planets);
        }
}

2.Main.java

Java

package com.avengers;

public class Main {

    public static void main(String[] args) {

        Avenger[] avenger=new Avenger[5];
        for(int i=0;i<5;i++)
        {
            avenger[i]=new Avenger();
            avenger[i].getDetails();
            System.out.println("Data at index "+i);
            avenger[i].displayDetails();
        }

    }
}

What I have tried:

I tried to print all the properties of avenger object but it prints only values at last index of the array i.e. Hulk data.

Posted 15-Oct-20 20:09pm

Bhavishya Jain

Updated 15-Oct-20 21:01pm

CPallini

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nelek · Answer 1 · 2020-10-15T20:55:00

That's because your GetDetails in the main is being called within a for loop, and the GetDetails function already has another for loop.

So the return value that you get is the last one.

Change your GetDetails function to return only one position of the array and give that position as a parameter

EDIT: Additionally, just a thought.
I would change the way you name things.
In my case I use the "names" for the array and the "name" as a single value.

I mean:

Java

String[] names = {"Iron Man","Captain America","Thor","Black Widow","Hulk"};
...
...
...
name = names[i]

CPallini · Answer 2 · 2020-10-15T21:01:00

I suppose you should end up with an array of Avengers.
Try, for instance:

Java

public class Avenger
{
  String name , weapon,planet;
  int age , power;

  public Avenger(String name, String weapon, String planet,int  age, int power )
  {
    this.name = name;
    this.weapon = weapon;
    this.planet = planet;
    this. age = age;
    this.power = power;
  }

  public void displayDetails()
  {
    System.out.println("Name: " + name);
    System.out.println("Age: " + age);
    System.out.println("Power: " + power);
    System.out.println("Weapon: " + weapon);
    System.out.println("Planet: " + planet);
  }

  public static void main( String arg[])
  {
    Avenger [] avenger = AvengerFactory.getAvengers();
    for (Avenger a : avenger)
    {
      a.displayDetails();
      System.out.println();
    }
  }
}

class AvengerFactory
{

  final static int Avengers = 5;
  final static String[] name = {"Iron Man","Captain America","Thor","Black Widow","Hulk"};
  final static String[] weapon = {"Repulsor","Shield","Stormbreaker","Baton","Mjolnir"};
  final static String[] planet = {"Titan","Earth","Asgard","Vormir","Sakaar"};
  final static int[] age = {48,27,1500,34,58};
  final static int[] power = {9,10,20,6,8};

  static Avenger [] s_avenger = null;

  public static Avenger[] getAvengers()
  {
    if ( s_avenger == null )
      createAvengers();
    return s_avenger;
  }

  static void createAvengers()
  {
    s_avenger = new Avenger[Avengers];
    for (int i=0; i<Avengers; ++i)
    {
      s_avenger[i] = new Avenger(name[i], weapon[i], planet[i], age[i], power[i]);
    }
  }
}

The code below needs some changes. It prints only values at last index of array. Please suggest some changes.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0